From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 12 Oct 2022 16:05:36 GMT
Subject: Re: [PATCH v2 08/22] run-command.c: use C99 "for (TYPE VAR = ..." syntax where useful
Message-ID: <xmqq35btm3hr.fsf@gitster.g>
In-Reply-To: <ae08523f-13ac-d9aa-b787-f136a88b5804@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

>>   	while (1) {
>> -		for (i = 0;
>> +		for (int i = 0;
>
> Here we are moving the declaration to the loop.
>
> Am I missing something, I don't understand how these changes match
> this description in the commit message

It matches the commit title, and makes it clear that this does not
have to be part of this series.

Ævar, try to do a focused series that achieves the objective of the
topic well, without succumbing to the temptation of creature feep.
It is especially important when you are taking other peoples' series
hostage by requesting them to rebase on you.

Thanks.