From: Junio C Hamano Date: Wed, 26 Apr 2023 17:38:27 GMT Subject: Re: [PATCH v3 1/2] negotiator/default: avoid stack overflow Message-ID: In-Reply-To: <49695ce0-b9f9-0fc7-ed16-093dc7f12b7e@github.com> Derrick Stolee writes: > It is unfortunate that the logic for nw->common_revs is duplicated, > but I think this is a cleaner approach than other considered > approaches. It is subjective and as long as the result works correctly, I am fine with it ;-). Thanks.