From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 06 May 2024 17:52:07 GMT
Subject: Re: [PATCH v5 0/3] builtin/tag.c: add --trailer option
Message-ID: <xmqq34quzv3s.fsf@gitster.g>
In-Reply-To: <ZjhtZb5nJZ8vlvLw@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

> On Sun, May 05, 2024 at 06:49:07PM +0000, John Passaro via GitGitGadget wrote:
>> 5th follow-up patch taking welcome feedback from Patrick and JCH. Net new
>> changes include suggested tweaks in documentation, error messaging, code
>> formatting, and patch description.
>> 
>> Since git-tag --list --format="%(trailers)" can interpret trailers from
>> annotated tag messages, it seems natural to support --trailer when writing a
>> new tag message.
>> 
>> git-commit accomplishes this by taking --trailer arguments and passing them
>> to git-interpret-trailer. This patch series refactors that logic and uses it
>> to implement --trailer on git-tag.
>
> This version looks good to me, thanks!

Thanks.  Will queue.