From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 10 May 2024 21:03:09 GMT
Subject: Re: [PATCH v2 01/11] reftable: consistently refer to `reftable_write_options` as `opts`
Message-ID: <xmqq34qp4bxu.fsf@gitster.g>
In-Reply-To: <7efa56630681b6aca64c04fd19fb020ffbb76152.1715336798.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

>  int reftable_new_stack(struct reftable_stack **dest, const char *dir,
> -		       struct reftable_write_options config);
> +		       struct reftable_write_options opts);

Passing struct by value is somewhat unusual.  As long as the
structure does not contain any pointer to something else, it is not
too bad as structure assignment would also work well, though.  Not a
fault of this patch, and this series is not a place to change
anything about it.

> -	if (config.hash_id == 0) {
> -		config.hash_id = GIT_SHA1_FORMAT_ID;
> -	}
> +	if (opts.hash_id == 0)
> +		opts.hash_id = GIT_SHA1_FORMAT_ID;

Nice attention to detail.