From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 04 Feb 2025 13:38:07 GMT
Subject: Re: [PATCH 1/2] help: show the suggested command when help.autocorrect is false
Message-ID: <xmqq34gtx22o.fsf@gitster.g>
In-Reply-To: <20250204030501.GD23954@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Feb 03, 2025 at 02:53:00PM -0800, Junio C Hamano wrote:
>
>> David Aguilar <davvid@gmail.com> writes:
>> 
>> > Make the handling of false boolean values for help.autocorrect
>> > consistent with the handling of value 0 by showing the suggested
>> > commands but not running them.
>> >
>> > Suggested-by: Junio C Hamano <gitster@pobox.com>
>> > Signed-off-by: David Aguilar <davvid@gmail.com>
>> > ---
>> > This is based on the sc/help-autocorrect-one patches from this thread
>> > and is in response to the open question from "What's coooking in git.git":
>> >
>> >> On Fri, 31 Jan 2025 18:51:33 -0800 Junio C Hamano <gitster@pobox.com> wrote:
>> >> Looking good except for "should 0 and false be 'tell it without doing it'?".
>> >
>> > source: <xmqq5xlu4bt6.fsf@gitster.g>
>> >
>> > This is what it would look like if the answer were to be, "yes".
>> 
>> I obviously like the updated semantics myself.
>> Thanks for updating it.
>> 
>> Let's see what others think.
>
> I like it (including the new "show" which is even more descriptive).

Thanks, really appreciate it.