From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 10 Jan 2026 02:25:16 GMT
Subject: Re: [PATCH v2][next] hook: check for NULL pointer before deref
Message-ID: <xmqq344etd9v.fsf@gitster.g>
In-Reply-To: <20260109181912.689409-1-adrian.ratiu@collabora.com>

Adrian Ratiu <adrian.ratiu@collabora.com> writes:

> Fix a compiler warning (-Werror=analyzer-deref-before-check) due to
> dereferencing the options pointer before NULL checking it.
>
> In practice run_hooks_opt() is never called with a NULL opt struct,
> so this just fixes the code to not trigger the warning anymore.
>
> The NULL check is kept as-is because some future patches might end up
> calling run_hooks_opt with a NULL opt struct, which is clearly a bug.
>
> While at it, also fix the BUG message function name.
>
> Reported-by: correctmost <cmlists@sent.com>
> Suggested-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
> ---
> This is based on next, because it fixes a warning introduced in next.

Actually the problematic topic has been in 'master' for a few days
already, isn't it?  I'd apply directly on top of ar/run-comand-hook
topic.

Thanks.