From: Junio C Hamano Date: Tue, 17 Mar 2026 21:52:31 GMT Subject: Re: [PATCH 1/5] revision: include object-name.h Message-ID: In-Reply-To: "Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > The REV_INFO_INIT macro includes a use of the DEFAULT_ABBREV macro, which is > defined in object-name.h. Include it in revision.h so consumers of > REV_INFO_INIT do not need to include this hidden dependency. > > Signed-off-by: Derrick Stolee > --- > revision.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/revision.h b/revision.h > index b36acfc2d9..18c9bbd822 100644 > --- a/revision.h > +++ b/revision.h > @@ -4,6 +4,7 @@ > #include "commit.h" > #include "grep.h" > #include "notes.h" > +#include "object-name.h" > #include "oidset.h" > #include "pretty.h" > #include "diff.h" OK. Other symbols REV_INFO_INIT needs are REV_SORT_IN_GRAPH_ORDER (in ), CMIT_FMT_DEFAULT (in ), and STRVEC_INIT (in ), and all three are already included there. Makes sense.