From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 30 Mar 2026 22:59:49 GMT
Subject: Re: [PATCH v4 2/6] xdiff: use unambiguous types in xdl_bogo_sqrt()
Message-ID: <xmqq341g7wka.fsf@gitster.g>
In-Reply-To: <86b0ad100ccbcd1812b24eabd0abe1987592daa0.1774890003.git.gitgitgadget@gmail.com>

"Ezekiel Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> -	xenv.mxcost = xdl_bogosqrt(ndiags);
> +	xenv.mxcost = (long)xdl_bogosqrt((uint64_t)ndiags);

There is nothing actionable, but this makes me wonder if we want to
update the type of .mxcost member (which seems to never go negative)
somehow.  I also wonder if uint32_t should be sufficiently wide for
xdl_bogosqrt() that takes uint64_t.