From: Junio C Hamano Date: Fri, 06 Sep 2013 17:29:34 GMT Subject: Re: [PATCH 0/5] branch: Fix --track on a remote-tracking non-branch Message-ID: In-Reply-To: <1378464042-17476-1-git-send-email-johan@herland.net> Johan Herland writes: > However, in addition to requiring a matching remote/refspec, I also > (for reasons that are still unclear to me) added a requirement that > the resulting remote ref name (to be stored into branch..merge) > must start with "refs/heads/" (see the last line of > branch.c:check_tracking_branch()). > > Although it is typically the case that an upstream branch is a proper > (refs/heads/*) branch in the remote repo (which explains why we have > not noticed this until now), I think it is _wrong_ of Git to _require_ > this when configuring the upstream. Yeah, I agree.