From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 Jun 2014 23:02:30 GMT
Subject: Re: [PATCHv3 5/5] t7510: test verify-commit
Message-ID: <xmqq1tufb56h.fsf@gitster.dls.corp.google.com>
In-Reply-To: <340919e5e17a582acaa57faefb362141e64d32a1.1403506792.git.git@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

>  test_expect_success GPG 'detect fudged signature' '
>  	git cat-file commit master >raw &&
>  
>  	sed -e "s/seventh/7th forged/" raw >forged1 &&
>  	git hash-object -w -t commit forged1 >forged1.commit &&
> +	! git verify-commit $(cat forged1.commit) &&

This should be "test_must_fail git verify-commit ...", I think.
Otherwise you would end up declaring a segfaulting implementation a
good one.

> +	! git verify-commit $(cat forged2.commit) &&

Likewise.