From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 16 Sep 2015 21:51:13 GMT
Subject: Re: [PATCH 52/67] use sha1_to_hex_to() instead of strcpy
Message-ID: <xmqq1tdyowxa.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20150915160535.GZ29753@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> diff --git a/builtin/merge-index.c b/builtin/merge-index.c
> index 1d66111..4ed0a83 100644
> --- a/builtin/merge-index.c
> +++ b/builtin/merge-index.c
> @@ -9,7 +9,7 @@ static int merge_entry(int pos, const char *path)
>  {
>  	int found;
>  	const char *arguments[] = { pgm, "", "", "", path, "", "", "", NULL };
> -	char hexbuf[4][60];
> +	char hexbuf[4][GIT_SHA1_HEXSZ + 1];
>  	char ownbuf[4][60];

So you saved 19*4 = 76 bytes at runtime?

Looks good ;-).