From: Junio C Hamano Date: Fri, 11 Dec 2015 22:49:42 GMT Subject: Re: [PATCH/RFC 00/10] ref-filter: use parsing functions Message-ID: In-Reply-To: <1447271075-15364-1-git-send-email-Karthik.188@gmail.com> Karthik Nayak writes: > Karthik Nayak (10): > ref-filter: introduce a parsing function for each atom in valid_atom > ref-filter: introduce struct used_atom > ref-fitler: bump match_atom() name to the top > ref-filter: skip deref specifier in match_atom_name() > ref-filter: introduce color_atom_parser() > strbuf: introduce strbuf_split_str_without_term() > ref-filter: introduce align_atom_parser() > ref-filter: introduce remote_ref_atom_parser() > ref-filter: introduce contents_atom_parser() > ref-filter: introduce objectname_atom_parser() It seems that this series had seen quite a good inputs, mostly from Eric. I finished reading it over and I didn't find anything more to add. The patches are mostly good and would be ready once these points raised during the review are addressed, I think Thanks.