From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 14 Mar 2016 03:51:00 GMT
Subject: Re: [PATCH v1] git-p4: fix AsciiDoc formatting
Message-ID: <xmqq1t7dafa3.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <F0F4FA8A-EB42-4990-A90E-6C9245E0A9DE@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
>> index 738cfde..140fc12 100644
>> --- a/Documentation/git-p4.txt
>> +++ b/Documentation/git-p4.txt
>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::
>> git config       git-p4.largeFileSystem GitLFS
>> -------------
>> +
>> -	[1] https://git-lfs.github.com/
>> +[1] https://git-lfs.github.com/
>> 
>> git-p4.largeFileExtensions::
>> 	All files matching a file extension in the list will be processed
>> --
>> 2.5.1
>> 
>
> Is there any chance to get this in? The formatting error is quite obvious here:
> https://git-scm.com/docs/git-p4
>
> (while looking at this website I also noticed wrong double quotes around cp1252
> which I will fix with a subsequent patch)

I ignored this when I saw it first, primarily because I assumed that
anything related to git-p4 would get a review by somebody better
versed with git-p4 before I get to it; I forgot about the patch
after it was buried in the other messages without anything
happening.

Will take a look.

Thanks.