From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 07 Apr 2016 17:34:51 GMT
Subject: Re: [PATCH 2/4] builtin/interpret-trailers: suppress blank line
Message-ID: <xmqq1t6h1fwk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160407201853-mutt-send-email-mst@redhat.com>

"Michael S. Tsirkin" <mst@redhat.com> writes:

> No - but then I will need to re-run mailinfo to parse the result,
> will I not?

By the way, I suspect (if Christian did his implementation right
when he did interpret-trailers) all these points may become moot.

I haven't re-reviewed what is in interpret-trailers, but the vision
has been that its internal workings should be callable directly into
instead of running it via run_commands() interface passing the data
via on-disk file.  In the codepath you touch in 3/4 and 4/4, you
already have not just mi.log_message but msg that has the whole
payload to create a commit object out of already, so shouldn't it be
just the matter of passing <msg.buf, msg.len> to some API function
that was prepared to implement interpret-trailers?