From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 May 2016 20:11:02 GMT
Subject: Re: [PATCH v2 00/41] Add and use error_errno() and warning_errno()
Message-ID: <xmqq1t5inbqh.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1462277054-5943-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> Changes are in
>
>   [01/41] usage.c: move format processing out of die_errno()
>   [02/41] usage.c: add warning_errno() and error_errno()
>   [12/41] builtin/update-index.c: prefer "err" to "errno" in process_lstat_error
>   [17/41] compat/win32/syslog.c: use warning_errno()
>   [27/41] grep.c: use error_errno()
>
> 12/41 is basically a revert with s/strerror(errno)/strerror(err)/.
> Interdiff from v1

Thanks.  The earlier parts that lay the foundation looked good, and
most of the conversion of the callers were, too (I think there was
only one whose validity I wasn't sure about, though).

Some of the changes that are more than a straight and faithful
conversion, i.e. fixes to places that used to show an extra newline,
used to lack errno in the output, etc., deserve to be mentioned in
the log message of respective patches.

Thanks.