From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Aug 2016 22:16:14 GMT
Subject: Re: [PATCH v10 00/40] libify apply and use lib in am, part 2
Message-ID: <xmqq1t1yewk1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAP8UFD2t9PaC8hONJJuG2EUU=0NMUC1BaDDD2Hr0u21K5rhZ3Q@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

> diff --git a/apply.h b/apply.h
> index 27a3a7a..e2b89e8 100644
> --- a/apply.h
> +++ b/apply.h
> @@ -16,7 +16,7 @@ enum apply_ws_ignore {
>  enum apply_verbosity {
>      verbosity_silent = -1,
>      verbosity_normal = 0,
> -    verbosity_verbose = 1,
> +    verbosity_verbose = 1
>  };

Thanks for not forgetting this.

> @@ -107,20 +111,6 @@ struct apply_state {
>      int applied_after_fixing_ws;
>  };
>
> -extern int apply_option_parse_exclude(const struct option *opt,
> -                      const char *arg, int unset);
> -extern int apply_option_parse_include(const struct option *opt,
> -                      const char *arg, int unset);
> -extern int apply_option_parse_p(const struct option *opt,
> -                const char *arg,
> -                int unset);
> -extern int apply_option_parse_whitespace(const struct option *opt,
> -                     const char *arg, int unset);
> -extern int apply_option_parse_directory(const struct option *opt,
> -                    const char *arg, int unset);
> -extern int apply_option_parse_space_change(const struct option *opt,
> -                       const char *arg, int unset);
> -
>  extern int apply_parse_options(int argc, const char **argv,
>                     struct apply_state *state,
>                     int *force_apply, int *options,

Also these.