From: Junio C Hamano Date: Fri, 19 Jan 2018 21:57:35 GMT Subject: Re: [PATCH v3 1/3] read-cache: fix reading the shared index for other repos Message-ID: In-Reply-To: <20180107223015.17720-2-t.gummerer@gmail.com> Thomas Gummerer writes: > read_cache_from() defaults to using the gitdir of the_repository. As it > is mostly a convenience macro, having to pass get_git_dir() for every > call seems overkill, and if necessary users can have more control by > using read_index_from(). This was a bit painful change, given that some changes in flight do add new callsites to read_index_from() and they got the function changed under their feet. Please double check if I made the right git-dir to be passed to them when I push out 'pu' in a few hours. Thanks.