From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 26 Apr 2018 02:11:51 GMT
Subject: Re: [PATCH 01/11] t9902-completion: add tests demonstrating issues with quoted pathnames
Message-ID: <xmqq1sf24syg.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAM0VKjkQfTm+qnurvZ_545VXJH2PwuPfkhXaa1sLj5ePSPjBwA@mail.gmail.com>

SZEDER Gábor <szeder.dev@gmail.com> writes:

> These new tests, however, are primarily interested in the inner
> workings of __git_complete_index_file() in the presence of escapes
> and/or quotes in the path to be completed and/or in the output of 'git
> ls-files'.  For these kind of tests we could simply invoke
> __git_complete_index_file() directly, like we call __git_refs()
> directly to test refs completion.  Then we could set the current path
> to be completed to whatever we want, including spaces, because it
> won't be subject to field splitting like the command line given to
> 'test_completion'.
>
> So, I think for v2 I will rewrite these tests to call
> __git_complete_index_file() directly instead of using
> 'test_completion', and will include a test with spaces in path names.

Quite well thought-out reasoning.  Thanks.