From: Junio C Hamano Date: Sun, 13 May 2018 23:45:09 GMT Subject: Re: [PATCH v2 04/14] describe: use commit-slab for commit names instead of commit->util Message-ID: In-Reply-To: <20180513055208.17952-5-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > + slot = commit_names_peek(&commit_names, c); > + n = slot ? *slot : NULL; Seeing this and the helper in the previous step makes me wonder if we also want a "peek-and-then-peel" variant that encapsulates this pattern. We'll know when we read the series through. So far looking good. Thanks. > if (n) { > if (!tags && !all && n->prio < 2) { > unannotated_cnt++;