From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 23 Jul 2019 17:34:57 GMT
Subject: Re: [PATCH] grep: print the pcre2_jit_on value
Message-ID: <xmqq1rygu01q.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190722181923.21572-1-dev+git@drbeat.li>

Beat Bolli <dev+git@drbeat.li> writes:

> When pcre2_jit_on is neither 1 nor 0, the BUG() call printed the value
> of pcre1_jit_on.
>
> Print the value of pcre2_jit_on instead.
>
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> ---

Thanks.


>  grep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grep.c b/grep.c
> index f7c3a5803e..cd952ef5d3 100644
> --- a/grep.c
> +++ b/grep.c
> @@ -559,7 +559,7 @@ static void compile_pcre2_pattern(struct grep_pat *p, const struct grep_opt *opt
>  		pcre2_jit_stack_assign(p->pcre2_match_context, NULL, p->pcre2_jit_stack);
>  	} else if (p->pcre2_jit_on != 0) {
>  		BUG("The pcre2_jit_on variable should be 0 or 1, not %d",
> -		    p->pcre1_jit_on);
> +		    p->pcre2_jit_on);
>  	}
>  }