From: Junio C Hamano Date: Sat, 23 Nov 2019 00:18:05 GMT Subject: Re: [PATCH 1/1] gpg-interface: limit search for primary key fingerprint Message-ID: In-Reply-To: <87v9rby82a.hji@dyntopia.com> Hans Jerry Illikainen writes: > On Fri, Nov 22 2019, Junio C Hamano wrote: >> Wouldn't some of the fields this helper works on be of type "char *"? > > Wow, that's embarrassing. I completely messed that one up after a > looong day. Gah! Fixed and re-built with DEVELOPER=1 and re-ran the > test suite for both commits in an attempt to avoid further fuckups. The embarrassment is mine ;-) > I also fixed the criticism on 2/2 (even though you mentioned that > there's no need for that) and sent it as v4 because I'm not sure what > the right approach is for changing only 1/2. > > For future reference; how does the project prefer fixups for a single > commit on a multi-patch submission? Unless the series is insanely loooooooooooooooooooooooooooooooong, resending the whole thing, optionally with summary of the changes since the previous iteration for each step after the three-dash lines (i.e. this allows readers to notice "unchanged since v3" and skip individual ones marked as such while reviewing v4), would be a good way to help both reviewers who saw the previous round and those who have skipped the previous round. Thanks.