From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 30 Nov 2019 20:21:18 GMT
Subject: Re: [PATCH v2 0/2] Brown-bag fix on top of js/mingw-inherit-only-std-handles
Message-ID: <xmqq1rtp2k01.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <6beaf25f-1369-3e77-fd54-fdb5a1e63707@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

> Just like on POSIX the value of errno is indeterminate after a
> successful system call, the value of GetLastError() indeterminate after
> a successful Windows API call. Therefore, the err_win_to_posix() would
> not be able to point at a bogus caller reliably. For this reason, let's
> consider the function as a simple error code translator, and then
> translating ERROR_SUCCESS to 0 (or is there ESUCCESS?) makes total sense.

OK, that makes sense.

Thanks.