From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 15 Mar 2022 19:22:49 GMT
Subject: Re: [GSoC][PATCH v2] Add a diff driver for JavaScript languages.
Message-ID: <xmqq1qz3dnqu.fsf@gitster.g>
In-Reply-To: <kl6lee33xd5d.fsf@chooglen-macbookpro.roam.corp.google.com>

Glen Choo <chooglen@google.com> writes:

> Interesting, I'll take note. I'm still personally not keen on supporting
> CommonJS-only patterns when we are purportedly trying to show diffs for
> JavaScript, but if we think this fits the style, I'm happy to oblige.

The question is, with these patterns that are aware of CommonJS
convention, would your bog-standard-and-boring vanilla JS code be
detected incorrectly?  Becoming aware of popular conventions without
hurting others would be a good thing.

And the "popular conventions" does not have to be limited to
CommonJS/Node.