From: Junio C Hamano Date: Fri, 16 Jun 2023 16:03:42 GMT Subject: Re: [PATCH] setup.c: don't setup in discover_git_directory() Message-ID: In-Reply-To: <9a7602ba-6903-a94a-3bb5-e51c76f08058@gmx.de> Johannes Schindelin writes: >> As explained by 16ac8b8db6 (setup: introduce the >> discover_git_directory() function, 2017-03-13) and the comment on its >> declaration, discover_git_directory() is intended to be an entrypoint >> into setup.c machinery that allows the Git directory to be discovered >> without side effects, e.g. so that read_early_config() can read >> ".git/config" before the_repository has been set up. >> >> Fortunately, we didn't start to rely on this unintended behavior between >> then and now, so we let's just remove it. It isn't harming anyone, but >> it's confusing. >> >> Signed-off-by: Glen Choo > > As the author of the commit whose rationale was quoted above, I am > delighted to provide my ACK to both commit message and diff. > > Thanks, > Johannes Thanks, both, for writing and reviewing. Queued.