From: Junio C Hamano Date: Thu, 08 May 2025 13:28:43 GMT Subject: Re: What's cooking in git.git (May 2025, #03; Wed, 7) Message-ID: In-Reply-To: Johannes Sixt writes: > Am 08.05.25 um 03:26 schrieb Junio C Hamano: >> * md/userdiff-bash-shell-function (2025-04-01) 1 commit >> - userdiff: extend Bash pattern to cover more shell function forms >> >> The userdiff pattern for shell scripts has been updated to cope >> with more bash-isms. >> >> Comments? >> source: <20250330134018.9662-2-dhar61595@gmail.com> > > This round has room for improvement. I posted a review yesterday: > https://lore.kernel.org/git/9d548d94-eed8-434a-a9ef-67df694c5c79@kdbg.org/ Yeah, I indeed saw your thoughtful review. Thanks for pointing this out.