From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 11 Mar 2026 17:32:52 GMT
Subject: Re: [PATCH] editorconfig: fix style not applying to subdirs anymore
Message-ID: <xmqq1phqqnjv.fsf@gitster.g>
In-Reply-To: <1eb3b78c-5833-4fa9-83f6-237d4a3e78d3@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> On 11/03/2026 07:09, Patrick Steinhardt wrote:
>...
>>    If the glob contains a path separator (a / not inside square
>>    brackets), then the glob is relative to the directory level of the
>>    particular .editorconfig file itself. Otherwise the pattern may also
>>    match at any level below the .editorconfig level.
>> 
>> What's interesting is that the _whole_ expression is considered to be
>> the glob.
>
> Ouch, I'd missed that, thanks for fixing it
> ...
>>    [{{,**/}*.{c,h,sh,bash,perl,pl,pm,txt,adoc},config.mak.*,{,**/}Makefile,templates/hooks/*.sample}]
>>    indent_style = tab
>>    tab_width = 8
>> 
>> This starts to become somewhat hard to read, so the duplication feels
>> like the better tradeoff.
>
> Agreed

Thanks, both.