From: Junio C Hamano Date: Thu, 04 Jun 2026 01:09:33 GMT Subject: Re: [PATCH v6 0/2] config: suggest the correct form when key contains "=" Message-ID: In-Reply-To: "Harald Nordgren via GitGitGadget" writes: > * The quiet parameter now lives on a static do_parse_config_key() instead > of git_config_parse_key() itself. git_config_parse_key() is back to its > three-argument signature; existing callers don't change. > * New public git_config_key_is_valid() for callers that only need a yes/no > check. > > Harald Nordgren (2): > config: add git_config_key_is_valid() for quiet validation > config: improve diagnostic for "set" with missing value > > builtin/config.c | 32 ++++++++++++++++++++++++++- > config.c | 38 ++++++++++++++++++++++++-------- > config.h | 2 ++ > t/t1300-config.sh | 56 +++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 118 insertions(+), 10 deletions(-) Looking good. Thanks. Will queue.