From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 12 Aug 2026 18:04:21 GMT
Subject: Re: [GSoC PATCH v4 2/7] list-objects-filter: add list_objects_filter__filter_oidset()
Message-ID: <xmqq1pc3xlju.fsf@gitster.g>
In-Reply-To: <20260810174047.6524-3-r.siddharth.shrimali@gmail.com>

Siddharth Shrimali <r.siddharth.shrimali@gmail.com> writes:

> diff --git a/list-objects-filter.c b/list-objects-filter.c
> index c912ff3079..6a2e9d5b24 100644
> --- a/list-objects-filter.c
> +++ b/list-objects-filter.c
> @@ -828,3 +828,48 @@ void list_objects_filter__free(struct filter *filter)
> ...
> +	while ((oid = oidset_iter_next(&iter))) {
> +		struct object_info info = OBJECT_INFO_INIT;
> +		enum object_type type;
> +		unsigned long size;
> +
> +		info.typep = &type;
> +		info.sizep = &size;

Here "struct object_info" is defined as

        struct object_info {
                /* The object type. */
                enum object_type *typep;

                /* The inflated object size in bytes. */
                size_t *sizep;
                ...

but local "size" whose address is assigned to is of type "unsigned
long".