From: Michal Nazarewicz Date: Tue, 12 Feb 2013 22:50:27 GMT Subject: Re: [PATCHv4 4/6] Git.pm: allow pipes to be closed prior to calling command_close_bidi_pipe Message-ID: In-Reply-To: <7va9r9fd4e.fsf@alter.siamese.dyndns.org> On Tue, Feb 12 2013, Junio C Hamano wrote: > I would actually vote for the most explicit: > > _cmd_close($ctx, (grep { defined } ($in, $out))); To me that looks weird at best, but I don't have strong opinions on that matter. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo--