From: Michal Nazarewicz Date: Fri, 08 Feb 2013 01:37:53 GMT Subject: Re: [PATCHv2 4/5] Git.pm: add interface for git credential command Message-ID: In-Reply-To: <7v7gmj66fq.fsf@alter.siamese.dyndns.org> On Fri, Feb 08 2013, Junio C Hamano wrote: > I'd actually be more worried about the error checking issue > Peff raised during his review. I have a feeling that "when in doubt, > do not cause harm" is a more prudent way to go than "I do not know, > so I'll let anything pass". I can implement whatever checking you wish, just tell me what to do in corner cases I've listed. ;) -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo--