From: Brandon Casey Date: Tue, 26 May 2009 14:57:41 GMT Subject: Re: [PATCH 2/2] t8005: convert CP1251 character set to ISO8859-5 Message-ID: In-Reply-To: <20090525092027.GA22382@coredump.intra.peff.net> Jeff King wrote: > On Fri, May 22, 2009 at 06:06:06PM -0700, Junio C Hamano wrote: > >> It also appears that we do not need OLD_ICONV anymore, as our Makefile >> suggests for older releases. >> >> It would be nice if people with older Solaris can check if I am not >> breaking things for them... > > Git builds fine on my Solaris 8 test box with this patch. It also builds > fine if I drop OLD_ICONV, so it may be that we can unconditionally do > so (but I don't have any older boxen to test with). > > With current 'next' and NO_PERL set, I can pass every test except: Oh, and have the recent changes that are now in next _allowed_ any new tests to pass that were previously failing? -brandon