From: Matthieu Moy Date: Thu, 09 Sep 2010 06:04:16 GMT Subject: Re: Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list. Message-ID: In-Reply-To: <1284010826-81989-1-git-send-email-davi.reis@gmail.com> davi.reis@gmail.com writes: > Here is how to reproduce the bug: > > git init > mkdir prefix && touch prefix/a && git add prefix/a > mkdir prefixdir && touch prefixdir/b && git add prefixdir/b > git commit -a -m "If -r is not given, ls-tree should not show files in subdirs." > git ls-tree --name-only HEAD prefix # works as expected > git ls-tree --name-only HEAD prefixdir # works as expected > git ls-tree --name-only HEAD prefix prefixdir # shows file, not dir That's so close to a real test-case... You should incorporate this in your patch (e.g. in t/t3101-ls-tree-dirname.sh), to make sure such bug never happens again. -- Matthieu Moy http://www-verimag.imag.fr/~moy/