From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 07 Oct 2010 17:40:18 GMT
Subject: Re: git log doesn't allow %x00 in custom format anymore?
Message-ID: <vpqy6a952bh.fsf@bauges.imag.fr>
In-Reply-To: <20101007172939.GA12130@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> diff --git a/builtin/rev-list.c b/builtin/rev-list.c
> index efe9360..3b2dca0 100644
> --- a/builtin/rev-list.c
> +++ b/builtin/rev-list.c
> @@ -147,8 +147,10 @@ static void show_commit(struct commit *commit, void *data)
>  			}
>  		} else {
>  			if (revs->commit_format != CMIT_FMT_USERFORMAT ||
> -			    buf.len)
> -				printf("%s%c", buf.buf, info->hdr_termination);
> +			    buf.len) {
> +				fwrite(buf.buf, 1, buf.len, stdout);
> +				putchar(info->hdr_termination);
> +			}
>  		}
>  		strbuf_release(&buf);
>  	} else {

Sounds like a sane thing to do, yes.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/