From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 07 Aug 2013 09:23:37 GMT
Subject: Re: [PATCH] die_with_status: use "printf '%s\n'", not "echo"
Message-ID: <vpqy58dj1ly.fsf@anie.imag.fr>
In-Reply-To: <871u65yj0v.fsf@linux-k42r.v.cablecom.net>

Thomas Rast <trast@inf.ethz.ch> writes:

>> +	grep -v "	" error
>
> Umm, doesn't that only test that _some_ line in the error does not
> contain a tab?

Indeed. It does work as the error message is just a one-liner, but let's
be robust anyway.

> Whereas you need to test that _no_ line contains <TAB>emp, or some
> such.  Perhaps as
>
>   ! grep -v "	emp" error

Err, then the -v should be remove. Also, I'll use test_expect_code 1
instead of ! to catch other grep failures, just in case.

Thanks, new patch comming.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/