From: Matthieu Moy Date: Wed, 09 Oct 2013 11:26:19 GMT Subject: Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly Message-ID: In-Reply-To: Paolo Giarrusso writes: > Otherwise, one could > change say to use printf, but that's more invasive. "invasive" in the sense that it impacts indirectly more callers, but are there really cases where "echo" is needed when calling "say"? Aren't there other potential bugs when arbitrary strings are passed to "say", that would be fixed by using printf once and for all? The patch would look like the one I did in 89b0230a20 (Wed Aug 7 2013, die_with_status: use "printf '%s\n'", not "echo"). -- Matthieu Moy http://www-verimag.imag.fr/~moy/