From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Mon, 21 Jul 2014 13:45:56 GMT
Subject: Re: [PATCH v3 0/6] git_config callers rewritten with the new config cache API
Message-ID: <vpqy4vmakq3.fsf@anie.imag.fr>
In-Reply-To: <53CD1280.1080107@gmail.com>

Tanay Abhra <tanayabh@gmail.com> writes:

> On 7/21/2014 6:21 PM, Matthieu Moy wrote:
>> 2) Add a by-address parameter to git_configset_get_value that allows the
>>    user to get the file and line information. In your previous patch,
>>    that would mean returning a pointer to the corresponding struct
>>    key_source.
>
> Will this extra complexity be good for "git_configset_get_value"?
> Instead can we provide a function like die_config(char *key)
> which prints
> 	die("bad config file line %d in %s", linenr, filename);?

Where would you call this function, and where would you take linenr and
filename?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/