From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Fri, 26 Jun 2015 06:59:03 GMT
Subject: Re: [PATCH v9 5/5] bisect: allow any terms set by user
Message-ID: <vpqy4j7x8eg.fsf@anie.imag.fr>
In-Reply-To: <xmqqk2urwjmq.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>
>> +------------------------------------------------
>> +git bisect terms <term-new> <term-old>
>> +------------------------------------------------
>
> The mnemonic for "git bisect start bad good" is Bad comes before
> Good (B = 0x42, G = 0x47) and this is same for "new/old", New comes
> before Old (N = 0x4e, O = 0x4f).  "git bisect terms new old" follows
> the same pattern, which is good.  Easy to remember.
>
>> +This command has to be used before a bisection has started. <term-old>
>> +must be associated with the latest revisions and <term-new> with the
>> +ancestors of <term-old>.
>
> Whoa?  This gets new and old mixed up, doesn't it?

Right. I think it was already the case before, but using term1/term2 in
the text made it hard to spot. The new wording is clearer, and makes it
easier to find bugs in the explanations ;-).

>> +Only the first bisection following the `git bisect terms` will use the
>> +terms. If you mistyped one of the terms you can do again `git bisect
>> +terms <term-old> <term-new>`.
>
> This is also the other way around, no?

Indeed.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/