From: Matthieu Moy Date: Wed, 25 May 2011 15:50:16 GMT Subject: Re: [PATCH] Remove a dead assignment Message-ID: In-Reply-To: <20110525150631.GA29161@localhost> Chris Wilson writes: > On Wed, May 25, 2011 at 09:52:56AM +0200, Matthieu Moy wrote: >> Chris Wilson writes: >> >> > Oops, I see others putting the patches inline. Here you go. >> >> Please, read Documentation/SubmittingPatches. Especially read about >> signed-off-by and the way patches should be formatted (git send-email >> would help). > > Thanks, trying this again. Still not right ;-). The text here (above ---) will become the commit message when applied, and you don't want the commit message to mention this discussion. This discussion could have been added below ... > Like I said before, the author should investigate if this variable > should have been used before removing it. > > Signed-off-by: Chris Wilson > --- => this is the place for informal discussions. > sh-i18n--envsubst.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) If you don't follow this, then the maintainer has to do this manually, and we all prefer his time to be invested in better activities ;-). -- Matthieu Moy http://www-verimag.imag.fr/~moy/