From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 11 Jun 2015 17:41:41 GMT
Subject: Re: [PATCH v7 05/12] for-each-ref: introduce new structures for better organisation
Message-ID: <vpqwpzarvl6.fsf@anie.imag.fr>
In-Reply-To: <1434039003-10928-5-git-send-email-karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> +struct ref_filter_cbdata {
> +	struct ref_array array;
> +	struct ref_filter filter;
> +};

I didn't notice this at first, but why introduce the structure like this
when you are going to turn it into pointers later in PATCH 7:

Karthik Nayak <karthik.188@gmail.com> writes:

> --- a/ref-filter.h
> +++ b/ref-filter.h
> @@ -42,12 +45,17 @@ struct ref_filter {
>  };
>  
>  struct ref_filter_cbdata {
> -	struct ref_array array;
> -	struct ref_filter filter;
> +	struct ref_array *array;
> +	struct ref_filter *filter;
>  };

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/