From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 28 Jul 2015 07:26:17 GMT
Subject: Re: [PATCH v6 01/10] ref-filter: introduce 'ref_formatting_state'
Message-ID: <vpqwpxk215y.fsf@anie.imag.fr>
In-Reply-To: <1438065211-3777-1-git-send-email-Karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> -static void print_value(struct atom_value *v, int quote_style)
> +static void apply_formatting_state(struct ref_formatting_state *state,
> +				   struct atom_value *v, struct strbuf *value)
>  {
> -	struct strbuf sb = STRBUF_INIT;
> -	switch (quote_style) {
> +	/*  Eventually we'll formatt based on the ref_formatting_state */

s/formatt/format/

Also, we usually use a single space after /*.

(Neither is very important since it disapears in the next commit)

> +	/*
> +	 * Some (pesudo) atoms have no immediate side effect, but only

s/pesudo/pseudo/. But if you are to rename these atoms to "modifier
atoms", you should get rid of this "pseudo" here.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/