From: Matthieu Moy Date: Mon, 06 Jun 2016 16:17:38 GMT Subject: Re: [PATCH V2 3/3] strbuf: allow to use preallocated memory Message-ID: In-Reply-To: <20160606151340.22424-4-william.duclot@ensimag.grenoble-inp.fr> I'm waiting for the discussion "is this useful" to settle before I do a final review, but I went quickly through the code and it seems OK. Just to show I read till the end: William Duclot writes: > +test_expect_success 'check preallocated strbuf behavior in usual use cases' ' > + > + test-strbuf --preallocated_check_behavior Useless blank line. -- Matthieu Moy http://www-verimag.imag.fr/~moy/