From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Mon, 11 Mar 2013 16:47:40 GMT
Subject: Re: [RFC/PATCH] git-completion.bash: remove bashism to fix ZSH compatibility
Message-ID: <vpqtxohubmb.fsf@grenoble-inp.fr>
In-Reply-To: <7vobepany3.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> So here is an updated based on your patch.

Perfect, thanks.

> The correct thing to do in the longer term may be to stop dot-sourcing
> the source meant for bash into zsh, but this patch should suffice as
> a band-aid in the meantime.

I disagree with this particular part though. I think using the same code
for bash and zsh makes sense, and it implies restricting to the common
subset. I don't consider it "band-aid", but "nice code factoring" ;-).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/