From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Mon, 08 Sep 2014 19:29:31 GMT
Subject: Re: [RFC PATCH v2 1/2] Makefile: add check-headers target
Message-ID: <vpqsik13o84.fsf@anie.imag.fr>
In-Reply-To: <xmqqiokylz46.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> David Aguilar <davvid@gmail.com> writes:
>
>> +IFS='
>> +'
>> +git ls-files *.h ewah/*.h vcs-svn/*.h xdiff/*.h |
>
> Hmm.  This is only for true developers (not one who merely compiles
> after expanding a tarball), so "git ls-files" may probably be OK.
>
> But "/bin/ls" would be equally fine for that, no?

Actually, since this is "| while read header", I have to wonder why this
is not written as

for header in .h ewah/*.h vcs-svn/*.h xdiff/*.h
do
	...
done

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/