From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 23 Jun 2015 18:18:40 GMT
Subject: Re: [PATCH v7 3/5] bisect: simplify the addition of new bisect terms
Message-ID: <vpqsi9ixp8f.fsf@anie.imag.fr>
In-Reply-To: <CAPig+cSzymZ+JEO8sPrayQ+XNag0kAry_9_eH4=kSqPp=JKk7w@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Tue, Jun 23, 2015 at 8:54 AM, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:

>> +       strbuf_addstr(&bisect_refs_buf, "refs/bisect/");
>> +       strbuf_addstr(&bisect_refs_buf, name_bad);
>
> A single strbuf_addf() rather than two strbuf_addstr()s?

>> +       bisect_refs_str = strbuf_detach(&bisect_refs_buf, NULL);
>> +       status = for_each_ref_in_submodule(submodule, bisect_refs_str, fn, cb_data);
>> +       free((char *)bisect_refs_str);
>
> Why the above rather than the simpler?
>
>     strbuf_addstr(&bisect_refs, ...);
>     status = for_each_ref_in_submodule(submodule, bisect_refs.buf, fn, cb_data);
>     strbuf_release(&bisect_refs);
>
> What am I missing?

Indeed, your version is much better.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/