From: Matthieu Moy Date: Fri, 16 Oct 2015 16:54:45 GMT Subject: Re: [PATCH v2 0/4] stripspace: Implement and use --count-lines option Message-ID: In-Reply-To: <1445008605-16534-1-git-send-email-tklauser@distanz.ch> Tobias Klauser writes: > - Split patch 2/3 into two patches: patch 2/4 switches git stripspace > to use parse-options and patch 3/4 introduces the new option. Much better now. > - Implement line counting in cmd_stripbuf() instead of (ab-)using > strbuf_stripspace() for it. Also short and sweet, I like it. > - Drop -C short option > - Correct example command output in documentation. > - Adjust commit messages to not include links to the wiki, fully > describe the motivation in the commit message instead. Good. I read the patches again, and the whole series is now Reviewed-by: Matthieu Moy -- Matthieu Moy http://www-verimag.imag.fr/~moy/