From: Matthieu Moy <matthieu.moy@imag.fr>
Date: Thu, 12 Mar 2009 09:47:01 GMT
Subject: Re: [PATCH 1/2] Add a test for checking whether gitattributes is honored by checkout.
Message-ID: <vpqr613jcoa.fsf@bauges.imag.fr>
In-Reply-To: <1236850575-27973-2-git-send-email-kristian.amlie@nokia.com>

Kristian Amlie <kristian.amlie@nokia.com> writes:

> +test_expect_success 'setup' '

If you have two separate patches for test and bugfix, you probably
want the first to introduce test_expect_failure, and the second to
change it to test_expect_success. This way: 1) the test-suite passes
for all commits (and git-bisect will be your friend again), and 2) the
second patch is self-explanatory about the bug it fixes.

-- 
Matthieu