From: Matthieu Moy Date: Wed, 25 Jan 2012 22:02:04 GMT Subject: Re: [PATCH] git-completion: workaround zsh COMPREPLY bug Message-ID: In-Reply-To: Felipe Contreras writes: >>> +             typeset -h IFS >> >> No time to test right now, but is this not going to >> >> 1) leave IFS as hidden even outside the completion script, possibly >> affecting unrelated scripts that would need to set IFS as local and keep >> its special effect? > > What special effect? > > Unrelated scripts can still set IFS as local. OK, I missed the fact that typeset -h had only local effect. >> 2) break cases where strings are to be split on \n only (e.g. see >> "foo bar\nboz" as three possible completions "foo", "bar", "boz" instead >> of "foo bar" and "boz"? > > Those cases are already broken, which is what I reported to the zsh > mailing list. You would get "foo\ bar" and "boz", and that's after > 4.3.12; before, compgen -W would still break the completions in 3, > because they did 'results+=( $words )', instead of 'results+=( > "$words" )'. Makes sense. I still have a minor comment: maybe part of your commit message could go to a comment in the code as well, in particular the "Once zsh is fixed" part, to help future contributors to actually disable the workaround when possible in the future. Tested-by: Matthieu Moy -- Matthieu Moy http://www-verimag.imag.fr/~moy/