From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 31 May 2012 06:44:28 GMT
Subject: Re: [PATCHv4 1/3] wt-status.*: better advices for git status added
Message-ID: <vpqr4u0rgs3.fsf@bauges.imag.fr>
In-Reply-To: <vpq1um0svgn.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

>> I doubt it makes much sense to hide only these messages behind "if
>> (advice_status_help)".  Look at how you give your "what to do"
>> advices in wt-status-merge-in-progress function.
>
> I disagree.

But I do agree with your updated suggestion (which I read too late):

Junio C Hamano <gitster@pobox.com> writes:

> So an updated suggestion would be to still move the whole thing to
> wt_status_print_state(), but not check advice.statusHints at the
> beginning of the function (as we will show what we find even when
> the user declines help text) and do the discovery, and hide the help
> messages (i.e. "do this to proceed") behind advice.statusHints,
> without introducing advice.statusHelp.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/