From: Matthieu Moy Date: Wed, 21 Aug 2013 21:52:15 GMT Subject: Re: [RFC PATCHv6 1/2] repack: rewrite the shell script in C Message-ID: In-Reply-To: Junio C Hamano writes: > Stefan Beller writes: > >> The motivation of this patch is to get closer to a goal of being >> able to have a core subset of git functionality built in to git. >> That would mean >> >> * people on Windows could get a copy of at least the core parts >> of Git without having to install a Unix-style shell >> >> * people deploying to servers don't have to rewrite the #! line >> or worry about the PATH and quality of installed POSIX >> utilities, if they are only using the built-in part written >> in C > > I am not sure what is meant by the latter. Rewriting #! is part of > any scripted Porcelain done by the top-level Makefile, and I do not > think we have seen any problem reports on it. I think the case of a server with exotic OS and totally broken /bin/sh would also benefit from this (the user won't have to find a non-broken sh and point SHELL_PATH to it). I have no concrete example though. >> + size_t len = strlen(e->d_name) - strlen(".pack"); > > decl-after-stmt. Stefan: you can make sure this does not happen again by adding CFLAGS += -Wdeclaration-after-statement in config.mak. -- Matthieu Moy http://www-verimag.imag.fr/~moy/