From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Mon, 23 Sep 2013 17:58:47 GMT
Subject: Re: [PATCH v2] git-remote-mediawiki: bugfix for pages w/ >500 revisions
Message-ID: <vpqr4cf773c.fsf@anie.imag.fr>
In-Reply-To: <1379957175-8606-1-git-send-email-benoit.person@gmail.fr>

Benoit Person <benoit.person@gmail.com> writes:

> The latest API renamed and moved the "continuing" information in the
> response, necessary to build the next query. The code failed to retrieve
> that information but still detected that it was in a "continuing
> query". As a result, it launched the same query over and over again.

Good, that's much cleaner.

> +		if ($result->{'query-continue'}) { # For legacy APIs
> +			$query->{rvstartid} = $result->{'query-continue'}->{revisions}->{rvstartid};
> +		} elsif ($result->{continue}) { # For newer APIs

I'd rather have the comments say "# API version < X" and "# API version
>= X". Next time the API change, "new" Vs "old" will become meaningless.

(But that should not block the patch from inclusion)

Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/